Add 2026–2035 roadmap & regulatory mapping plus validator, manifest, and test updates#108
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Changed Files
|
|
The files' contents are under analysis for test generation. |
|
View changes in DiffLens |
|
Review these changes at https://app.gitnotebooks.com/OneFineStarstuff/OneFineStarstuff.github.io/pull/108 |
There was a problem hiding this comment.
Sorry @OneFineStarstuff, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Warning Review limit reached
More reviews will be available in 50 minutes and 2 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThis pull request introduces a comprehensive 2026–2035 enterprise AGI/ASI governance framework, comprising master reference documentation, a phased roadmap, new validation functions, manifest updates, and extensive test coverage that ensures governance artifacts conform to required structure and content specifications. Changes2026–2035 Governance Blueprint Implementation
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Failed to generate code suggestions for PR |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 2 medium 3 minor |
| Documentation | 19 minor |
| ErrorProne | 9 high |
| CodeStyle | 59 minor |
| Complexity | 1 medium 1 minor |
🟢 Metrics 52 complexity · 0 duplication
Metric Results Complexity 52 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
for more information, see https://pre-commit.ci
|
View changes in DiffLens |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b843a05f43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…62035 Signed-off-by: 𝐎𝐧𝐞 𝐅𝐢𝐧𝐞 𝐒𝐭𝐚𝐫𝐬𝐭𝐮𝐟𝐟 <onefinestarstuff@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
View changes in DiffLens |
1 similar comment
|
View changes in DiffLens |
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
governance_blueprint/artifact_manifest.json (1)
3-32:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winDrop the duplicated keys before shipping this manifest.
JSON consumers typically keep only the last occurrence of a duplicate key, so this file currently resolves to
version: "1.4.5", the oldergenerated_utc, and the older hashes for the duplicatedvalidation/*entries. The new metadata and hashes on Lines 3-21 are effectively ignored.Suggested fix
- "version": "1.4.0", - "generated_utc": "2026-05-06T09:06:00Z", - "version": "1.4.5", - "generated_utc": "2026-04-28T02:47:09Z", + "version": "1.4.0", + "generated_utc": "2026-05-06T09:06:00Z", ... - "validation/validate_artifacts.py": "1c87eecb899b4b5ce98a0ae88d45146ab9b5dfb7842f4e0b0f11fdea13bf212d", - "validation/selftest_validate_artifacts.py": "7fb6f397bb8247d9c9668e4dc3e28bced027fcb75e99cbdf69109581f2c0f60f", - "validation/selftest_generate_artifact_manifest.py": "5ee98a79e65473870addf150c38d84424e3fb2091d0c925d1fee04940e7e10c5", - "validation/generate_artifact_manifest.py": "3305d6a4b18f1e8d15a580dbbaf45e9d4110ecd948f1a7a3085ecb83295f6c5d", - "validation/run_validation_suite.py": "b7147dae309723216a23078689c910e76bc6fa3934fb0c4516be1ff9239d2edc", - "validation/selftest_run_validation_suite.py": "58618918af699ec6f7e2358fd6932d5d3b85ce5efc0187e6c9e69d4d8520fd5a", ... - "validation/validate_artifacts.py": "a82ba842ada8a22d3d8cd37553b4c71691ec2da32f6add3c18a7baa9b0cbc1a7", - "validation/generate_artifact_manifest.py": "528970f9f6e35a0c50fd97c0551cc9230b2c7ce967f7b590a2dea2821d19c41c", - "validation/run_validation_suite.py": "2e00f22a83e572424b07ba9f6984394c8b99d2317fb40134fd2dd97d6708a2b6", + "validation/validate_artifacts.py": "1c87eecb899b4b5ce98a0ae88d45146ab9b5dfb7842f4e0b0f11fdea13bf212d", + "validation/generate_artifact_manifest.py": "3305d6a4b18f1e8d15a580dbbaf45e9d4110ecd948f1a7a3085ecb83295f6c5d", + "validation/run_validation_suite.py": "b7147dae309723216a23078689c910e76bc6fa3934fb0c4516be1ff9239d2edc", ... - "validation/selftest_generate_artifact_manifest.py": "381af02a7b337e11af7df7992012736a5ec9a37b1009c8aa3e918ad589baa8d2", - "validation/selftest_run_validation_suite.py": "697fdd88db942deb2a4d4f5cb17cabd5c36ce4278e7c6e70c9059c97fa1f47c1", - "validation/selftest_validate_artifacts.py": "84e95dfe25db9586c1806fda0fba1f4e8bb10b6c02360a224b12cddb7d82c06c" + "validation/selftest_generate_artifact_manifest.py": "5ee98a79e65473870addf150c38d84424e3fb2091d0c925d1fee04940e7e10c5", + "validation/selftest_run_validation_suite.py": "58618918af699ec6f7e2358fd6932d5d3b85ce5efc0187e6c9e69d4d8520fd5a", + "validation/selftest_validate_artifacts.py": "7fb6f397bb8247d9c9668e4dc3e28bced027fcb75e99cbdf69109581f2c0f60f"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@governance_blueprint/artifact_manifest.json` around lines 3 - 32, The manifest contains duplicated top-level keys ("version", "generated_utc") and repeated artifact entries (e.g., "validation/validate_artifacts.py", "validation/generate_artifact_manifest.py", "validation/run_validation_suite.py", "validation/selftest_*" etc.) so JSON consumers keep only the last occurrence; remove the older duplicate blocks and keep the intended/current values and hashes (or merge them) so each artifact path and each top-level key appears exactly once; update the "version" and "generated_utc" to the correct final values and ensure each validation/* entry uses the correct, non-duplicated checksum listed in the intended set.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@governance_blueprint/validation/generate_artifact_manifest.py`:
- Around line 166-170: The current logic indents the full-manifest comparison
under the artifacts branch so that generated_utc/external_artifacts drift is
ignored when artifacts match; in generate_artifact_manifest.py, dedent the
second if (the check using current_obj != expected_obj) so it runs at the same
level as the artifacts comparison (i.e., check artifacts with current_artifacts
and expected_artifacts, then separately check the full manifest using
current_obj and expected_obj) and keep the existing print message when the
full-manifest mismatch is detected.
- Around line 130-133: In build_manifest(), remove the duplicate stale entry
"version": "1.4.5" so the dict only contains the intended "version": "1.4.0" (or
update the single version key to the correct current version) — locate the
returned dict in function build_manifest() and delete the extra "version" line
to prevent the wrong value from being retained by the literal.
In `@governance_blueprint/validation/run_validation_suite.py`:
- Around line 81-86: The code adds three explicit selftest scripts then also
appends everything returned by _selftest_scripts(), causing duplicates; modify
the block where skip_selftest is handled to avoid scheduling duplicates by
either (A) removing the three hardcoded steps and rely solely on
_selftest_scripts(), or (B) filter _selftest_scripts() so you skip any script
equal to "governance_blueprint/validation/selftest_validate_artifacts.py",
"governance_blueprint/validation/selftest_generate_artifact_manifest.py", or
"governance_blueprint/validation/selftest_run_validation_suite.py" before
appending to steps; update the logic around skip_selftest, steps, and
_selftest_scripts() accordingly so each selftest appears only once.
In `@governance_blueprint/validation/selftest_generate_artifact_manifest.py`:
- Around line 50-55: The test is patching a non-existent attribute DEFAULT_FILES
and raising AttributeError; update the test to patch gm.BASE_DEFAULT_FILES
instead wherever DEFAULT_FILES is set/restored (e.g., replace gm.DEFAULT_FILES =
["dummy.txt"] and old_default_files = gm.DEFAULT_FILES with
gm.BASE_DEFAULT_FILES = ["dummy.txt"] and old_base_default_files =
gm.BASE_DEFAULT_FILES, and restore gm.BASE_DEFAULT_FILES from the saved old
value after the test), applying the same change at the other occurrences noted
(lines ~61-63, ~123-128, ~138-140) so the helpers can access the correct
attribute during gm.main().
- Around line 17-18: Move the second "from __future__ import annotations" and
any duplicated module docstring/imports to the top of
governance_blueprint/validation/selftest_generate_artifact_manifest.py (before
DUMMY_CONTENT/DUMMY_HASH) so all future imports are at file-start, and remove
the duplicate imports/docstring; ensure DUMMY_CONTENT and DUMMY_HASH remain
below those top imports. In
governance_blueprint/validation/generate_artifact_manifest.py add a proper
indented body for the "if current_artifacts != expected_artifacts:" check (e.g.,
raise AssertionError or log and return/exit) so the module can import, and
ensure the check performs the intended --check behavior. Finally, update the
test patching approach: instead of patching gm.DEFAULT_FILES (which isn't used),
patch BASE_DEFAULT_FILES or call/override _default_files() in
generate_artifact_manifest so the generator actually sees the intended defaults.
In `@governance_blueprint/validation/validate_artifacts.py`:
- Around line 396-412: The function validate_master_reference_markdown currently
appends missing-section messages to errors but never returns errors on the
normal path; add a final return errors at the end of
validate_master_reference_markdown so it returns [] for successful validations
and the populated list when failures are found (preserve the existing
early-return for the missing file case and keep the required_patterns loop and
errors variable as-is).
- Around line 258-300: The function validate_roadmap_2035_shape() collects
validation messages into the local variable errors but never returns it, causing
callers expecting a list to receive None; fix by adding a final "return errors"
at the end of validate_roadmap_2035_shape so the function's declared return type
list[str] is satisfied and downstream callers (e.g., run_checks() / selftests)
receive the collected errors.
In `@Makefile`:
- Around line 67-70: The Makefile contains a duplicate governance-check target
that merged stale prerequisites (governance-validate and
governance-reports-validate) causing incorrect behavior; remove the
stale/duplicate governance-check definition and keep a single governance-check
target whose prerequisites use the current names (e.g., governance-test,
governance-schema-validate, governance-validate-json-check) and deduplicate the
.PHONY list so only one .PHONY declaration includes governance-check.
---
Outside diff comments:
In `@governance_blueprint/artifact_manifest.json`:
- Around line 3-32: The manifest contains duplicated top-level keys ("version",
"generated_utc") and repeated artifact entries (e.g.,
"validation/validate_artifacts.py", "validation/generate_artifact_manifest.py",
"validation/run_validation_suite.py", "validation/selftest_*" etc.) so JSON
consumers keep only the last occurrence; remove the older duplicate blocks and
keep the intended/current values and hashes (or merge them) so each artifact
path and each top-level key appears exactly once; update the "version" and
"generated_utc" to the correct final values and ensure each validation/* entry
uses the correct, non-duplicated checksum listed in the intended set.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 177ffb53-5140-4f6a-99a5-244f7a93d879
⛔ Files ignored due to path filters (1)
governance_blueprint/regulatory_playbook_mapping_2026_2035.csvis excluded by!**/*.csv
📒 Files selected for processing (12)
.gitignoreENTERPRISE_AGI_ASI_GOVERNANCE_MASTER_REFERENCE_2026_2035.mdMakefilegovernance_blueprint/artifact_manifest.jsongovernance_blueprint/roadmap_2026_2035.yamlgovernance_blueprint/validation/README.mdgovernance_blueprint/validation/generate_artifact_manifest.pygovernance_blueprint/validation/run_validation_suite.pygovernance_blueprint/validation/selftest_generate_artifact_manifest.pygovernance_blueprint/validation/selftest_run_validation_suite.pygovernance_blueprint/validation/selftest_validate_artifacts.pygovernance_blueprint/validation/validate_artifacts.py
Micro-Learning Topic: External entity injection (Detected by phrase)Matched on "XXe"An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server-side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts. Try a challenge in Secure Code WarriorHelpful references
|
❌ Deploy Preview for onefinestarstuff failed.
|
…62035 Signed-off-by: 𝐎𝐧𝐞 𝐅𝐢𝐧𝐞 𝐒𝐭𝐚𝐫𝐬𝐭𝐮𝐟𝐟 <onefinestarstuff@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
View changes in DiffLens |
Motivation
Description
ENTERPRISE_AGI_ASI_GOVERNANCE_MASTER_REFERENCE_2026_2035.md,governance_blueprint/roadmap_2026_2035.yaml, andgovernance_blueprint/regulatory_playbook_mapping_2026_2035.csvand updated.gitignoreto ignore generated JSON suite/report files.governance_blueprint/artifact_manifest.jsonpackageversionto1.4.0and updated timestamps; updatedgenerate_artifact_manifest.pyto include the new files, bumpversionto1.4.0, and add package/version mismatch checks when--checkis used.validate_artifacts.pywithvalidate_roadmap_2035_shape,validate_regulatory_mapping_csv, andvalidate_master_reference_markdown, and wired them intorun_checksand the suite runner.governance_blueprint/validation/selftest_generate_artifact_manifest.py, updatedselftest_validate_artifacts.pyandselftest_run_validation_suite.pyto cover the new validators and suite behavior, and updatedrun_validation_suite.pyto run the new selftest and support JSON/suite reports; adjustedMakefiletargets to reflect renamed schema validation target and new convenience targets.Testing
python3 -m unittest discover -s governance_blueprint/validation -p "selftest_*.py", which exercisedselftest_generate_artifact_manifest.py,selftest_validate_artifacts.py, andselftest_run_validation_suite.py, and all tests passed.python3 governance_blueprint/validation/run_validation_suite.py --quiet --json-report governance-artifact-validation-report.json --suite-report governance-validation-suite-report.json(CI-like invocation) and the suite completed successfully writing both JSON reports.generate_artifact_manifest.py --check,generate_artifact_manifest.py --stamp-now, and the manifest hash checks via the new unit tests, and those checks passed.Codex Task
Summary by CodeRabbit
Documentation
Tests